Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpcs support #317

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add rpcs support #317

merged 4 commits into from
Feb 16, 2022

Conversation

enomis-dev
Copy link
Contributor

Proposed changes

Linked to #316

  • rpcs initialization in constructor (rpcs can be specified in 3 different ways and are stored in a rasterio.rpc.RPC object)
  • added property method to access rpcs
  • improved save method to save rasters with rpcs
  • improved reprojection. Reprojection now supports rpcs and the use of the DEM (passed as kwarg)
  • added unit tests for constructor, reprojection

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #317 (f6cdcbd) into master (69c353a) will increase coverage by 0.02%.
The diff coverage is 92.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   90.84%   90.86%   +0.02%     
==========================================
  Files          38       38              
  Lines        6070     6130      +60     
==========================================
+ Hits         5514     5570      +56     
- Misses        556      560       +4     
Impacted Files Coverage Δ
telluric/util/raster_utils.py 91.47% <85.71%> (+0.35%) ⬆️
telluric/georaster.py 93.43% <87.50%> (-0.21%) ⬇️
tests/test_georaster.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c353a...f6cdcbd. Read the comment docs.

Copy link
Contributor

@arielze arielze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @SimoneDeGasperis

Copy link
Contributor

@drnextgis drnextgis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @SimoneDeGasperis!

@drnextgis drnextgis merged commit 0f0758b into satellogic:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants