-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable transformation if source CRS equals to destination #270
Conversation
22375e5
to
a67ed3d
Compare
7ea41e3
to
fb9cfe6
Compare
fb9cfe6
to
f25e0cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge! Added a few minor comments in case you have time to address them
@@ -49,7 +49,8 @@ def transform(shape, source_crs, destination_crs=None, src_affine=None, dst_affi | |||
if src_affine is not None: | |||
shape = ops.transform(lambda r, q: ~src_affine * (r, q), shape) | |||
|
|||
shape = generate_transform(source_crs, destination_crs)(shape) | |||
if source_crs != destination_crs: | |||
shape = generate_transform(source_crs, destination_crs)(shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -42,7 +42,7 @@ | |||
'packaging', | |||
'pycodestyle', | |||
'pytest>=4', | |||
'pytest-cov', | |||
'pytest-cov<=2.8.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What problems does the new version have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.