Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable transformation if source CRS equals to destination #270

Merged
merged 2 commits into from
Jun 27, 2020

Conversation

drnextgis
Copy link
Contributor

No description provided.

@drnextgis drnextgis force-pushed the footprint-issue branch 4 times, most recently from 22375e5 to a67ed3d Compare June 26, 2020 23:33
@drnextgis drnextgis requested a review from astrojuanlu June 26, 2020 23:42
@drnextgis drnextgis force-pushed the footprint-issue branch 2 times, most recently from 7ea41e3 to fb9cfe6 Compare June 27, 2020 06:56
Copy link
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge! Added a few minor comments in case you have time to address them

tests/test_geovector.py Show resolved Hide resolved
@@ -49,7 +49,8 @@ def transform(shape, source_crs, destination_crs=None, src_affine=None, dst_affi
if src_affine is not None:
shape = ops.transform(lambda r, q: ~src_affine * (r, q), shape)

shape = generate_transform(source_crs, destination_crs)(shape)
if source_crs != destination_crs:
shape = generate_transform(source_crs, destination_crs)(shape)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -42,7 +42,7 @@
'packaging',
'pycodestyle',
'pytest>=4',
'pytest-cov',
'pytest-cov<=2.8.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problems does the new version have?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drnextgis drnextgis merged commit d7aed56 into master Jun 27, 2020
@drnextgis drnextgis deleted the footprint-issue branch June 27, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants