Changes to convert to cog #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrojuanlu
reviewed
Aug 22, 2018
telluric/util/raster_utils.py
Outdated
| return create_option | ||
|
|
||
|
|
||
| def convert_to_cog(source_file, destination_file, resampling=rasterio.enums.Resampling.gauss, blocksize=256, |
There was a problem hiding this comment.
Is create_option a dictionary? If so, we should add a docstring and probably rename it to create_options
There was a problem hiding this comment.
check out the docstring of convert_to_cog
telluric/util/raster_utils.py
Outdated
| def convert_to_cog(source_file, destination_file, resampling=Resampling.gauss): | ||
| def _create_options_for_cog(create_option, source_profile, blocksize): | ||
| """ | ||
| it useses the profile of the source raster, override anything using the creation_options |
There was a problem hiding this comment.
uses, create_options, guarantees
telluric/util/raster_utils.py
Outdated
| with TemporaryDirectory() as temp_dir: | ||
| temp_file = os.path.join(temp_dir, 'temp.tif') | ||
| rasterio_sh.copy(source_file, temp_file, tiled=True, compress='DEFLATE', photometric='MINISBLACK') | ||
| # rasterio_sh.copy(source_file, temp_file, **create_option) |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 89.34% 89.41% +0.06%
==========================================
Files 30 30
Lines 4270 4279 +9
==========================================
+ Hits 3815 3826 +11
+ Misses 455 453 -2
Continue to review full report at Codecov.
|
astrojuanlu
reviewed
Aug 22, 2018
telluric/util/raster_utils.py
Outdated
| """Convert source file to a Cloud Optimized GeoTiff new file. | ||
|
|
||
| :param source_file: path to the original raster | ||
| :param destination_file: path to the new raster | ||
| :param resampling: which Resampling to use on reading, default Resampling.gauss | ||
| :param blocksize: the size of the blocks default 256 | ||
| :param overview_blocksize: the block size of the overviews, default 256 | ||
| :param create_options: <dictioanry>, options that can override the source raster profile, |
There was a problem hiding this comment.
s/dictioanry/dictionary/g
telluric/util/raster_utils.py
Outdated
| :param blocksize: the size of the blocks default 256 | ||
| :param overview_blocksize: the block size of the overviews, default 256 | ||
| :param create_options: <dictioanry>, options that can override the source raster profile, | ||
| notice that you can't override tiled=True, and the blocksize |
There was a problem hiding this comment.
The user can't override the blocksize because it's a separate parameter of the function, right?
telluric/util/raster_utils.py
Outdated
| def _create_options_for_cog(create_options, source_profile, blocksize): | ||
| """ | ||
| it uses the profile of the source raster, override anything using the creation_options | ||
| and grantees we will have tiled raster and blocksize |
There was a problem hiding this comment.
s/grantees/guarantees/g
telluric/util/raster_utils.py
Outdated
| def convert_to_cog(source_file, destination_file, resampling=Resampling.gauss): | ||
| def _create_options_for_cog(create_options, source_profile, blocksize): | ||
| """ | ||
| it uses the profile of the source raster, override anything using the creation_options |
There was a problem hiding this comment.
s/creation_options/create_options/g
astrojuanlu
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not specifying the the compressing or no-data but using what comes from the source
allowing the user to add some creation parameters
we lost the behaviour of mask, I want to do it somwhen else so I opnned a ticket #133