Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use in a workflow with a comma in its name #69

Open
tyilo opened this issue Oct 30, 2020 · 3 comments
Open

Can't use in a workflow with a comma in its name #69

tyilo opened this issue Oct 30, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@tyilo
Copy link

tyilo commented Oct 30, 2020

Describe the bug
You can't use this with a worflow containing a comma in its name.

Debug logs

Run satackey/[email protected]
  with:
    key: docker-layer-caching-Build, Test & Deploy-{hash}
    restore-keys: docker-layer-caching-Build, Test & Deploy-
    concurrency: 4
    skip-save: false
  env:
    DOCKER_IMAGE_NAME: ghcr.io/fredagscafeen/web
ValidationError: Key Validation Error: docker-layer-caching-Build, Test & Deploy-{hash} cannot contain commas.
    at checkKey (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:41761:15)
    at Object.<anonymous> (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:41784:13)
Error: ValidationError: Key Validation Error: docker-layer-caching-Build, Test & Deploy-{hash} cannot contain commas.
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:41718:71
    at new Promise (<anonymous>)
    at module.exports.692.__awaiter (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:41714:12)
    at Object.restoreCache (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:41774:12)
    at LayerCache.restoreRoot (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:33245:45)
    at LayerCache.restore (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:33227:45)
    at main (/home/runner/work/_actions/satackey/action-docker-layer-caching/v0.0.8/dist/ttsc-dist/main.js/index.js:44116:42) {
  name: 'ValidationError'
}

Runner Environment (please complete the following information):

  • OS: ubuntu-latest
  • Action version: v0.0.8
@tyilo tyilo added the bug Something isn't working label Oct 30, 2020
@rcowsill
Copy link
Contributor

rcowsill commented Dec 2, 2020

https://github.com/actions/cache has the same restriction, cache keys can't contain ,

@tyilo
Copy link
Author

tyilo commented Dec 3, 2020

https://github.com/actions/cache has the same restriction, cache keys can't contain ,

Yeah, so this action shouldn't use the workflows name in the key for its cache.

@rcowsill
Copy link
Contributor

rcowsill commented Dec 4, 2020

Ah, fair point. actions/cache doesn't set a default key, unlike this action.

Until this is resolved it can be worked around by setting key and restore-keys explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants