Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add APPNAME when starting a SAS 9.4 IOM connection #762

Open
brunomueller opened this issue Jan 17, 2024 · 5 comments
Open

add APPNAME when starting a SAS 9.4 IOM connection #762

brunomueller opened this issue Jan 17, 2024 · 5 comments
Assignees
Labels
feature request New feature or request

Comments

@brunomueller
Copy link

brunomueller commented Jan 17, 2024

Is your feature request related to a problem? Please describe.
Looking at the log file of the Object Spawner we see the following:

2024-01-17T14:29:12,910 INFO [00000105] :sasdemo - New client connection (20) accepted from server port 8591 for user sasdemo. ... :56408 for APPNAME=SAS Data Integration Studio.

2024-01-17T14:33:34,293 INFO [00000130] :sasdemo - New client connection (22) accepted from server port 8591 for user sasdemo. ... :56800.

2024-01-17T14:38:32,804 INFO [00000173] :sasdemo - New client connection (26) accepted from server port 8591 for user sasdemo. ... :61221 for APPNAME=SAS Enterprise Guide.

The first line is the request to start a workspace server from SAS Data Integration Studio
The second line is the request to start a workspace server from the SAS VSCode extension
The third line is the request to start a workspace server from SAS Enterprise Guide

Describe the solution you'd like
Would be great to see an APPNAME= as well when starting a workspace server from VSCode

This will help anyone analysing Object Spawner log files

Environment
SAS version: SAS9.4 M8
SAS Extension for VSCode: 1.6.0

@scnwwu scnwwu added the feature request New feature or request label Jan 18, 2024
@DominiqueLatour
Copy link

I am currently working with Ralph Abbey and Xin Hunt on PROC REGISTERMODEL to register models to Model Manager. That will enable users to register models from workbench and SAS Studio. One of the requirements is to have the environment the model was created. For example, when submitting code form SAS Studio, the following macros are initialized by SAS Studio:
%let _clientapp = %nrquote(%nrstr(SAS Studio));
%let _clientappabbrev = %nrquote(%nrstr(Studio));
%let _clientappversion=2020;

This enables us to fetch that information. It would be great that in the VS Code plug for workbench to have similar macros to enable use to retrieve that we are in "VS Code SAS" and have the version.

Casey Smith told me that Bruno had already entered a similar request although not specific to workbench

@snlwih snlwih changed the title add APPNAME when starting a SAS9.4 IOM connection add APPNAME when starting a SAS 9.4 IOM connection Jan 31, 2024
@snlwih
Copy link
Collaborator

snlwih commented Jan 31, 2024

@DominiqueLatour, sounds to me that what you describe is slighly different from what Bruno is asking for.

Bruno is just asking for providing client info on the request that initiates a server connection, so the object spawner log shows which client requested a server session. When I interpret your suggestions correctly, you are asking for client-generated macro variables that represent the name of the client application and its version number, so you can take advantage of that information in the SAS code you are submitting.

Could you please create a dedicated GitHub Issue for this, so we can track this easier going forward? Once you have created it, we will add a link to it in this comment thread.

@snlwih
Copy link
Collaborator

snlwih commented Jan 31, 2024

@brunomueller, am I correct in saying that SAS applications like SAS Data Integration Studio and SAS Enterprise Guide only provide their appname and no version information on the request? Just double-checking.

@brunomueller
Copy link
Author

@snlwih yes the APPNAME= only contains the application name, see the very first entry.

@snlwih
Copy link
Collaborator

snlwih commented Nov 18, 2024

#1264 will be used to track the request for having the SAS extension generate connection type agnostic SAS macro variables that represent things like -name-of-file-being-submitted, name-of-directory-containing-file-being-submitted, client-app-version, client-app-name, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants