fix: use vscode.open to open file #1297
Conversation
|
I switched to using openWith in my latest changes because renaming a folder requires closing all files within the folder (for sas server, where the uris change as part of renaming). This change would effectively make it such that we close N files (where N > 1) but only re-open 1 file (unless preview mode is disabled) |
Hi @scottdover, I tried with this PR, it successfully re-opened all closed files. When calling |
Summary
Fix #1289
Need to use
vscode.opento open file with correct UI instead of always opening with the default code editor.It looks like the reason using
vscode.openWithwas to setpreviewtofalse. In my opinion we should not always setpreviewtofalse. It's possible that the file was in preview mode before closing, in which case it doesn't make sense to re-open withpreview: false. The tab closing is noticeable to end user. We even ask user to save or not save the file before closing. So I think it's OK to re-open with preview mode, same as if user close and re-open.Testing
Test case in #1289