Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: (PSKD-348) Dependency version update #401

Merged
merged 11 commits into from
Oct 10, 2024
Merged

feat!: (PSKD-348) Dependency version update #401

merged 11 commits into from
Oct 10, 2024

Conversation

riragh
Copy link
Member

@riragh riragh commented Oct 8, 2024

Changes:

This PR updates all the Terraform modules, providers, and other dependencies versions to latest. Also cleans up any old, unused code.

Notes:

  • The impact on variable change was kept minimal but please make sure to use the updated example files.
  • As this a major version update with breaking changes direct upgrade is not recommended, please remove your old infrastructure and then use the newer version.

Version Update summary:

Provider version updates

Tests:

Verifying following scenarios:

Scenario Task Provider Cadence Deploy Method Notes
1 OOTB, default, monitoring log enabled Azure fast:2020 Terraform See additional verification note below
2 OOTB, host encryption enabled Azure stable:2024.06 Terraform  
3 OOTB, Microsoft Entra authentication with Kubernetes RBAC Azure lts:2023.03 Terraform  
4 OOTB, Storage_type: HA Azure fast:2020 Terraform  
5 OOTB, external PG Azure - Docker  

Additional Verification:

  • Verified public ip sku is set to standard
  • Verified autoscaling is enabled
  • Verified docker_bridge_cidr is removed
  • Verified api_server_access_profile range is set as expected
  • Verified node taints were removed
  • Verified VM node acceleration is enabled

@riragh riragh added the enhancement New feature or request label Oct 8, 2024
@riragh riragh self-assigned this Oct 8, 2024
@riragh riragh changed the title Version update feat!: (PSKD-348) Dependency version update Oct 8, 2024
Copy link

@joboon joboon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot here, and I am unfamiliar with most of it. However, the changes look consistent and match with the discoveries detailed in PSKD-348, so I'll toss my approval. I think David and/or Chris should also review before merging.

Copy link
Member

@dhoucgitter dhoucgitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh merged commit 651c565 into staging Oct 10, 2024
4 checks passed
@riragh riragh deleted the version_update branch October 10, 2024 15:23
@riragh riragh mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants