feat: (IAC-1336) Add support for specifying K8s support plan #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoucgitter
approved these changes
Jan 26, 2024
sayeun
reviewed
Jan 29, 2024
sayeun
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enables user to specify the K8s support plan for the AKS cluster to add support for AKS LTS K8s versions. New variable
aks_support_plancluster_support_tieris introduced with possible valuesKubernetesOfficialandAKSLongTermSupport. Defaults toKubernetesOfficial.AKSLongTermSupport can only be enabled along with SKU tier Premium. For details see Long term Support and for which K8s version has long term support see AKS Kubernetes release calendar.
Tests:
Verified following scenarios, see internal ticket for details:
aks_support_plancluster_support_tier = "AKSLongTermSupport", network defaults:aks_network_plugin = "kubenet", aks_network_policy = null, aks_network_plugin_mode = nullaks_support_plancluster_support_tier= "AKSLongTermSupport", aks_network_plugin = "azure", aks_network_policy = "azure", aks_network_plugin_mode = "overlay"aks_support_plancluster_support_tier= "AKSLongTermSupport", network defaultsaks_support_plancluster_support_tier= "KubernetesOfficial", network defaults