Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add kubelet_disk_type to compute node pools #363

Open
Carus11 opened this issue Jan 31, 2024 · 1 comment · May be fixed by #385
Open

Feature Request: add kubelet_disk_type to compute node pools #363

Carus11 opened this issue Jan 31, 2024 · 1 comment · May be fixed by #385
Labels
enhancement New feature or request iac-pm PM Review required

Comments

@Carus11
Copy link

Carus11 commented Jan 31, 2024

We would like to use the kubernetes emptyDir volumes as the sas work location, and in order to utilise the local ephemeral ssd's on the compute nodes we need to specify kubelet_disk_type=Temporary
https://registry.terraform.io/providers/hashicorp/azurerm/3.86.0/docs/resources/kubernetes_cluster_node_pool#kubelet_disk_type

This will put emptyDir on the temporary storage on the node, see https://learn.microsoft.com/en-us/samples/azure-samples/aks-ephemeral-os-disk/aks-ephemeral-os-disk/

When setting the value of [kubeletDiskType](https://github.com/Azure/azure-rest-api-specs/blob/5582a35deb1bfa4aa22bac8f1d51b7934ead94ac/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2021-02-01/managedClusters.json#L3846-L3857) equal to Temporary, the operating system is hosted by the OS disk, no matter if the OS disk is managed or ephemeral, while container images, emptyDir volumes, and container logs are hosted by the temporary storage.

We are not allowed to use hostPath volumes. The requested property is available in the azurerm version used in this project, we just need the variable surfaced.

@riragh riragh added the enhancement New feature or request label Feb 1, 2024
@riragh riragh added the iac-pm PM Review required label Feb 14, 2024
@riragh
Copy link
Member

riragh commented Feb 14, 2024

After internal discussions, a feature request ticket PMFR4PLTFND-96 was opened to add support for os_disk_type. The variable kubelet_disk_type can be added along with that.

@Carus11 Carus11 linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iac-pm PM Review required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants