Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1120) Add support for gp3 #185

Open
joshcoburn opened this issue Feb 10, 2023 · 3 comments
Open

feat: (IAC-1120) Add support for gp3 #185

joshcoburn opened this issue Feb 10, 2023 · 3 comments

Comments

@joshcoburn
Copy link

Add support for gp3

@dhoucgitter
Copy link
Member

gp3 volumes are available in all AWS commercial and gov cloud regions according to this AWS announcement.

@joshcoburn
Copy link
Author

joshcoburn commented Dec 6, 2023

@dhoucgitter understood.. this feature request was more about ensuring that gp3 is a fully supported across the board option within the IAC. Further, it might be worth considering this as the default option across the board as well from a pricing/performance standpoint: see AWS article Migrate from gp2 to gp3 and save up to 20% on costs. However, I acknowledge this would be viewed as breaking change.

The EKS worker nodes currently support gp3 as is using tfvars: set os_disk_type parameter to gp3 and os_disk_iops parameter to min of 3000 within each node group.

The vms also currently support gp3 as is using tfvars: set os_disk_type to gp3 and os_disk_iops to min of 3000. Additionally if NFS is selected, the data_disk_type and data_disk_iops should also be set accordingly.

The only challenge I currently see, is the default_nodepool_os_disk_type .. there is currently a validation check that prohibits users from specifying gp3 disk without needing to modify the main variables.tf. So options here would be either expand the validation check to also include gp3 disk or get rid of the validation check altogether. Interestingly, none of the other disk type variables have a validation check implemented.

Other considerations outside the scope of IAC: EKS default storageclass is set to gp2 disk. SAS Viya utilizes this default storageclass for redis and opendistro PV. Additionally, viya4-monitoring uses default storageclass. So if gp3 disks across the board are desired, the default storageclass would also need to be updated to gp3.

@sayeun sayeun added the iac-pm Requires PM review label Dec 7, 2023
@sayeun sayeun changed the title feat: Add support for gp3 feat: (IAC-1120) Add support for gp3 Dec 7, 2023
@sayeun
Copy link

sayeun commented Dec 7, 2023

This requires PM review.

@dhoucgitter dhoucgitter removed the iac-pm Requires PM review label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants