Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (IAC-1242) where are V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables actually being used in this project? #493

Closed
1 task done
miaeyg opened this issue Oct 3, 2023 · 3 comments · Fixed by #550
Labels
bug Something isn't working

Comments

@miaeyg
Copy link

miaeyg commented Oct 3, 2023

Viya4 Deployment Version Details

Deploy on Azure

Ansible Variable File Details

No response

Steps to Reproduce

Deploy SAS Viya 4 on Azure using a Jump server and an NFS Server

Expected Behavior

I would expect the V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables to be used somewhere in the deployment but cannot find any such usage.
Can someone please tell me?

Actual Behavior

No usage found for these defined variables in the deployment files

Additional Context

No response

References

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@miaeyg miaeyg added bug Something isn't working new Added to an issue when it's new ;) labels Oct 3, 2023
@miaeyg miaeyg changed the title Where is V4_CFG_RWX_FILESTORE_ASTORES_PATH used in this project? Question: where are V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables actually being used in this project? Oct 3, 2023
@sayeun
Copy link

sayeun commented Oct 10, 2023

@miaeyg
Copy link
Author

miaeyg commented Oct 10, 2023

Yes, I am aware that these options are documented but I cannot find anywhere within the project where they are actually being used. I searched all files for these two variables and got zero results. I am wondering if these options are being used at all...

@jarpat jarpat removed the new Added to an issue when it's new ;) label Dec 1, 2023
@jarpat
Copy link
Contributor

jarpat commented Dec 1, 2023

Hey @miaeyg.

I do see that we create the astores and bin directory here https://github.com/sassoftware/viya4-deployment/blob/main/roles/jump-server/tasks/main.yml#L41 but it's always going to be created under JUMP_SVR_RWX_FILESTORE_PATH

Looking at old PRs when this V4_CFG_RWX_FILESTORE_ASTORES_PATH was initially renamed it seems that it was never used then either, perhaps it was a placeholder? PR #43

An internal Jira story will be created to track this.

@jarpat jarpat changed the title Question: where are V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables actually being used in this project? fix: (IAC-1242) where are V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables actually being used in this project? Dec 1, 2023
@jarpat jarpat linked a pull request May 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants