Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASComputeDeleteSession session_name parameter name #27

Open
nicrobert opened this issue Jan 5, 2024 · 2 comments
Open

SASComputeDeleteSession session_name parameter name #27

nicrobert opened this issue Jan 5, 2024 · 2 comments

Comments

@nicrobert
Copy link

It looks like the parameter to specify the session name is "session_name" in the class header. However, it does not work and seems to be "compute_session_name".

To be aligned with SASComputeCreateSession, "session_name" should be preferable.

@AndrewShakinovsky-SAS
Copy link
Collaborator

I don't think that the session_name in SASComputeCreateSession and the session id (I assume you meant compute_session_id because I don't see a compute_session_name) are referring to the same thing.
In SASComputeCreateSession the session_name is the name you want to give the session whereas the compute_session_id is the actual id that was assigned to it by compute. The studio operator does not (currently) allow you to assign a session name, it only allows passing in of a pre-existing id, or to try to look up the session id using the default "Airflow-Session" name.

@nicrobert
Copy link
Author

"compute_session_name" in sas_delete_session.py line 42 is mismatched with "session_name" as documented in line 34 of the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants