Make types.String.prototype.setValue() de-quote a string (#535)

Closes #513

Author: nex3

CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.15.2
+
+### Node JS API
+
+* When `setValue()` is called on a Sass string object, make it unquoted even if
+  it was quoted originally, to match the behavior of Node Sass.
+
 ## 1.15.1
 
 * Always add quotes to attribute selector values that begin with `--`, since IE

lib/src/node/value/string.dart

@@ -26,7 +26,7 @@ final Function stringConstructor = createClass(
 }, {
   'getValue': (_NodeSassString thisArg) => thisArg.dartValue.text,
   'setValue': (_NodeSassString thisArg, String value) {
-    thisArg.dartValue = SassString(value, quotes: thisArg.dartValue.hasQuotes);
+    thisArg.dartValue = SassString(value, quotes: false);
   },
   'toString': (_NodeSassString thisArg) => thisArg.dartValue.toString()
 });

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sass
-version: 1.15.1
+version: 1.15.2
 description: A Sass implementation in Dart.
 author: Dart Team <[email protected]>
 homepage: https://github.com/sass/dart-sass

test/node_api/value/string_test.dart

@@ -45,7 +45,7 @@ void main() {
           equalsIgnoringWhitespace("a { b: bar; c: foo; }"));
     });
 
-    test("a quoted string preserves quoting, even when its value is set", () {
+    test("a quoted string becomes unquoted when its value is set", () {
       expect(
           renderSync(RenderOptions(
               data: r"a {b: foo('foo')}",
@@ -57,7 +57,7 @@ void main() {
                   return string;
                 }))
               }))),
-          equalsIgnoringWhitespace('a { b: "bar"; }'));
+          equalsIgnoringWhitespace('a { b: bar; }'));
     });
   });