Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Task and Skip task doesn't work for script task/send task/milestones #1927

Open
madhurrya opened this issue Jul 16, 2024 · 5 comments · Fixed by #2026
Open

Execute Task and Skip task doesn't work for script task/send task/milestones #1927

madhurrya opened this issue Jul 16, 2024 · 5 comments · Fixed by #2026
Assignees

Comments

@madhurrya
Copy link
Contributor

madhurrya commented Jul 16, 2024

When I try to run 'Execute Task' and 'Skip task ' options in a script task/send task/milestones while the instance is suspended it gives this error.
'ProcessInstanceCannotBeRunError: Process instance '35' has status 'suspended' and therefore cannot run.'

But it works fine for a Manual task.
May be it doesn't work for any non human tasks? I checked only with a script task and send task and milestones.

Update : this doesn't happen in dev.app and dev.mod. Only happens in Time tracker and https://sample.spiffcrm.com/
So not sure whether this is also connected to the migration updates.

Image

Test model:
https://sample.spiffcrm.com/process-models/misc:qa:madhu-testing:test-model-1
https://timetracking.spiffworkflow.org/process-models/misc:qa:madhu-testing:test-model-with-milestones
https://dev.app.spiff.status.im/process-models/misc:test:madhurya-testing:test-model-with-milestones
https://dev.mod.spiff.status.im/process-models/misc:test:madhurya-testing:test-model-with-milestones

@madhurrya madhurrya changed the title Execute Task and Skip task doesn't work for script task/send task Execute Task and Skip task doesn't work for script task/send task/milestones Jul 16, 2024
@jasquat
Copy link
Contributor

jasquat commented Jul 16, 2024

This is related to a new check we added to avoid running do_engine_steps unintentionally on suspended process instances. We'll have to put in an exception for this code path.

@jasquat
Copy link
Contributor

jasquat commented Jul 16, 2024

Fixed with dfce83c. I meant to put that in a branch but it's a pretty small change.

@jasquat jasquat self-assigned this Jul 16, 2024
@madhurrya
Copy link
Contributor Author

@jasquat execute is working, but when I try to do Skip Task it gives this error.
image

@jasquat
Copy link
Contributor

jasquat commented Aug 2, 2024

@jbirddog @essweine was log_info removed during the other event logging work? It should be an easy fix if so.

@jasquat jasquat mentioned this issue Aug 2, 2024
@essweine
Copy link
Collaborator

essweine commented Aug 2, 2024

I changed the name of the method to collect collect_log_extras, which I thought made more sense. I see you've already figured that out.

@jasquat jasquat reopened this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants