Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Repeating Sections #300

Open
danfunk opened this issue Apr 29, 2022 · 0 comments
Open

Improve Repeating Sections #300

danfunk opened this issue Apr 29, 2022 · 0 comments

Comments

@danfunk
Copy link
Contributor

danfunk commented Apr 29, 2022

Formly has a nice example of a repeating section that doesn't work at all like the one we have now. What we do now is open a nice popup window, and then allow people to enter new information. Once complete, it displays what was entered on the main page as a block of text. You can continue to add new elements. It's looks lovely and works well in most circumstances, but has also been the source of a number of bugs. It requires some complex display components to render a form as something that isn't a form. And as described below, it hides what you have entered previously because each time you get a popup that covers all the past entries. The default behavior of formly, just allows you to add as many forms to the page as you like, and delete them as you like. It's not as pretty, but is it vastly easier to maintain, and it doesn't suffer from the issues listed below from Bugden.

Original feedback from Bugden / Documents for IRB / Question 2
--- snip ---
When you are selecting how you are
collecting/sending the HIPAA ID (original source,
store long term at UVA, send/transmit), there
isn’t a save/cancel button. Not sure if it is better
to have that instead of clicking elsewhere on the
page.
When you are adding HIPAA IDs, suggesting
greying out “No HIPAA IDs will be recorded” as
an option if you actually are collecting HIPAA IDs.
Also suggest greying out HIPAA IDs if you’ve
already added them to your list so you don’t
accidentally add the same one twice. Because
with the pop-up, you can’t see which ones you’ve
already added.
And when you are on the HIPAA identifiers and
qualifiers page, you can’t see the check each that
apply. It looks like “check each that apply:
original source data collection (receive, collect,…”
It would be nicer if I didn’t have to click on it to
see what I chose.
Non UVA IRB documents- I found this page
harder to navigate. Would be easier to have 1
page to upload everything instead of clicking
through a number of pages. I’m not sure why it’s
not letting me get to the summary page. Is it
because I don’t have the non-UVA IRB approval
yet? I wonder if this should be in a different
section, because we wouldn’t get that until after
we have done pre-review with UVA IRB. In terms
of flow, makes it more confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant