Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip out quotes when user types them for error boundary error code #90

Open
burnettk opened this issue May 8, 2024 · 1 comment
Open

Comments

@burnettk
Copy link
Contributor

burnettk commented May 8, 2024

Alex: Another issue is that if the user enters the Error Code with quotes, which is our standard convention, it does not work. But does without quotes, which our standard convention says should be interpreted as a variable.

KB: yeah, that's confusing. i assume in this case there is no option to evaluate it.

Elizabeth Esswein: this field is always a string. So in fact, quotes would be misleading. People already get bitten when they put in a number and expect to be able to compare it to an int. Having quotes introduces the expectation that there could be other types besides strings.

KB: i wonder if we could just strip them out if you type them. first i thought helpful error message, but then i was like, that's annoying

Elizabeth Esswein: Stripping would be a viable option i think

@burnettk burnettk changed the title strip out quotes when user types them for error boundary event code strip out quotes when user types them for error boundary error code May 8, 2024
@burnettk burnettk transferred this issue from sartography/spiff-arena May 8, 2024
@madhurrya
Copy link

I think we'll have to do the same in Escalation codes also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issue
Development

No branches or pull requests

2 participants