Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to C# #1

Closed
santisq opened this issue Aug 7, 2023 · 3 comments · Fixed by #2
Closed

Refactoring to C# #1

santisq opened this issue Aug 7, 2023 · 3 comments · Fixed by #2
Assignees
@santisq
Labels
enhancement New feature or request

Comments

@santisq
Copy link
Owner

santisq commented Aug 7, 2023

No description provided.

@santisq santisq self-assigned this Aug 7, 2023
@santisq santisq added the enhancement New feature or request label Aug 7, 2023
@krzydoug
Copy link

krzydoug commented Apr 1, 2024

No description provided.

I'd like to upvote this but you haven't provided any details. :)

@santisq
Copy link
Owner Author

santisq commented Apr 1, 2024 •
edited
Loading

No description provided.

I'd like to upvote this but you haven't provided any details. :)

It's for making a binary module for the *Async functions 😅 soon™

@santisq
Copy link
Owner Author

santisq commented Jul 18, 2024

Hey @krzydoug was wondering if you could give me your opinion on which name to use for this parameter: PSNetScannerCommandBase.cs#L25-L28. It's essentially the time in ms to wait before outputting a "Timeout" result object. Also open to any suggestions before pushing this to the main branch and then publishing it.

@santisq santisq linked a pull request Jul 18, 2024 that will close this issue
Refactoring Module #2
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@santisq santisq

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring Module santisq/PSNetScanners
2 participants
@santisq @krzydoug