-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We should add vagrant-spk unpack
#274
Comments
@zenhack confirmed a fear I had, that the build scripts are not included in the SPK. I think we should fix that as part of this issue. Build scripts are super small and it would be good if the required information exists in an SPK to unpack it and then pack it again easily. |
It seems like this might be hard to do automatically; what files are
part of the build scripts? If we only include build.sh & setup.sh, any
helper scripts, Makefiles, etc. that are necessary may not be included.
Quoting Jacob Weisz (2020-07-22 18:08:16)
… ***@***.*** confirmed a fear I had, that the build scripts are not
included in the SPK.
I think we should fix that as part of this issue. Build scripts are
super small and it would be good if the required information exists in
an SPK to unpack it and then pack it again easily.
--
You are receiving this because you were mentioned.
Reply to this email directly, [2]view it on GitHub, or [3]unsubscribe.
Verweise
1. https://github.com/zenhack
2. #274 (comment)
3. https://github.com/notifications/unsubscribe-auth/AAGXYPQJG2B5I765CR4WZE3R45PNBANCNFSM4PE6EVMA
|
I feel like if we have the .sandstorm folder we should have most of it for most apps? At minimum, it'll put one in a good position to know what they're missing. (Of course, the only scenario you likely need to hunt down someone and ask for what's missing is if it's a proprietary app.) |
That's probably not a bad default.
Quoting Jacob Weisz (2020-07-22 18:50:35)
… I feel like if we have the .sandstorm folder we should have most of it
for most apps? At minimum, it'll put one in a good position to know
what they're missing. (Of course, the only scenario you likely need to
hunt down someone and ask for what's missing is if it's a proprietary
app.)
|
The
spk unpack
command mostly exists for Sandstorm itself to install an app. However, we should ensure that it is available to developers on Windows/Mac as well by supporting a vagrant-spk unpack command. A particular interest here is that a user may wish to grab old binaries out of an old SPK or may wish to swap out components of an existing SPK and repack it.So we should ensure the flow of vagrant-spk unpack -> vagrant-spk vm up -> vagrant-spk dev -> vagrant-spk pack is a workable flow for this.
Related discussion sandstorm-io/sandstorm#3391 (comment)
The text was updated successfully, but these errors were encountered: