Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support range requests #2464

Open
mrdomino opened this issue Aug 28, 2016 · 4 comments
Open

Support range requests #2464

mrdomino opened this issue Aug 28, 2016 · 4 comments
Labels
app-platform App/Sandstorm integration features

Comments

@mrdomino
Copy link
Contributor

This would be nice for a stupid project of mine. I bet it'd also make Groovebasin song previews seekable. See also #1499

@rchrd2
Copy link

rchrd2 commented Nov 24, 2017

👍 I second this request. Also for an mp3-based app.

Unlike #1499, my app isn't using the special static hosting (though it could if necessary (just have to learn how to use it)).

I wonder if it's really just a matter of passing through the headers to the app, and then it's up to the app to support the range request. If so, then seems like low hanging fruit.

@rchrd2
Copy link

rchrd2 commented Nov 24, 2017

@kentonv Is this as simple as passing the headers through and letting the app's http server handle those headers?

@Michael-S
Copy link
Contributor

@rchrd2 the Groove Basin app in Sandstorm for music hosting is really good, and supports mp3s. I've been using it off my personal Sandstorm installation for over a year.

@kentonv
Copy link
Member

kentonv commented Dec 3, 2017

@rchrd2 Almost. I only want to use the header whitelist for things that are very application-specific. Range requests are a standard part of HTTP, so should be handled by extending the HTTP-over-Cap'n-Proto structures to represent them.

As it happens I actually have a PR open proposing such protocol changes: #2887

But the code hasn't been updated to implement the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-platform App/Sandstorm integration features
Projects
None yet
Development

No branches or pull requests

5 participants