Skip to content

Conversation

@jasminduong
Copy link
Contributor

@jasminduong jasminduong commented Sep 21, 2025

  • Added a function to filter each type of user - basic user, admin user (study manager and user manager), super admin
  • Added a function to handle switching tabs and displaying the active tab
  • Created a table with the first row as the nav bar for user types and the second row as the existing table that displays user data info

Testing:
2. Check Admin Users Page -> Displays nav bar with "Super Admin" tab (active), "Admin User" tab, and "Basic User" tab
3. Navigate to "Super Admin" tab -> Displays only users with "Super Admin" user type
4. Navigate to "Admin User" tab -> Displays only users with "User Manager" or "Study Manager" user type
5. Navigate to "Basic User" -> Displays only users with "Basic User" user type
6. Change any of the user types in the table and click "Save Changes" -> User updates and displays in new user type tab
7. From "Add Administrator" update a current "Basic User" to an admin user or super admin user type -> Updated user is displayed in new user type tab

@jasminduong jasminduong linked an issue Sep 21, 2025 that may be closed by this pull request
@jasminduong jasminduong requested a review from arath7 September 21, 2025 20:50
@jasminduong jasminduong marked this pull request as ready for review September 25, 2025 22:23
Copy link
Collaborator

@arath7 arath7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing is to just remove the comments in the lines I mentioned in my comment

return allUsers.value?.filter((user: any) => user.role === Role.BasicUser);
});
// default active tab
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of the comments in L143, L152, L175 (and anywhere else I may have missed) just because they don't follow our labeling conventions in the rest of the file/repo

Copy link
Collaborator

@arath7 arath7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just get the branch up to date w main before merging 🚀

@jen-cui jen-cui force-pushed the 161-admin-page-tabs branch from f989e31 to 10ad0f4 Compare October 16, 2025 18:17
@jen-cui jen-cui merged commit 3b1fba7 into main Oct 16, 2025
3 checks passed
@jen-cui jen-cui deleted the 161-admin-page-tabs branch October 16, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin Page Tabs

4 participants