-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Works generator generates tests that fail miserably #513
Comments
Failing test 4) add "gem 'rspec-html-matchers'" in Gemfile |
That did fix the 4th failing test. |
Failing test 1) add to your environment file https://github.com/ndlib/curate_vanilla/blob/master/config/environments/staging.rb#L45 |
For test 2 & 3) Try running The LOCAL means "Raise the exceptions instead of using the exception handler." There may be something buried in there. |
Same errors with LOCAL=TRUE rspec ./spec/controllers/curation_concern/texts_controller_spec.rb |
@flyingzumwalt Actually, I believe it is working. However your application is treating exceptions as local. That was one thing I had setup for Curate's tests to assume that exceptions are not local. So the proposed solution would be to handle either case. |
Ah. Ok. I'll do that in my app, but this ticket will be important to address in Curate so that future adopters won't run into it. |
Absolutely. And shouldn't be closed. I believe your two steps are appropriate and should have the test case: "And the generated model tests work" |
As an interesting aside - curate is assuming the use of rspec. Even in the spec_support. |
Would it be useful to have something similar to sufia_models with curation_concerns (works)? |
In a freshly generated Rails app where I ran the
rails g curate -f
generator, When I runit adds a suite of 50+ tests. Most of those tests fail.
To get most of the generated tests to pass
I had to do the following:
In spec/spec_helper.rb, add
AND THEN
add these to Gemfile:
AND
That leaves 4 tests still failing
The text was updated successfully, but these errors were encountered: