From 8c85cd1bc9a6e63cb25975678149b1cb355a9591 Mon Sep 17 00:00:00 2001 From: d3oxy Date: Tue, 27 Oct 2026 16:32:08 +0530 Subject: [PATCH] fix(extensions): alias native browser namespace to patched chrome Chromium exposes a native `browser` namespace in extension contexts that is a separate object from `chrome`. The preload only patched `chrome`, so extensions reading APIs through `browser` (uBlock Origin, Plasmo-based extensions) bypassed every shim. Point `browser` at the patched `chrome` when it exists. Fixes #189 --- .../spec/extensions-spec.ts | 14 ++++++++++++++ .../src/renderer/index.ts | 12 ++++++++++++ 2 files changed, 26 insertions(+) diff --git a/packages/electron-chrome-extensions/spec/extensions-spec.ts b/packages/electron-chrome-extensions/spec/extensions-spec.ts index c08bb1a5..c6cf61ba 100644 --- a/packages/electron-chrome-extensions/spec/extensions-spec.ts +++ b/packages/electron-chrome-extensions/spec/extensions-spec.ts @@ -1,6 +1,8 @@ import { expect } from 'chai' import { session } from 'electron' import { ElectronChromeExtensions } from '../' +import { waitForBackgroundPage } from './crx-helpers' +import { useExtensionBrowser } from './hooks' describe('Extensions', () => { const testSession = session.fromPartition('test-extensions') @@ -19,4 +21,16 @@ describe('Extensions', () => { }) }).to.throw() }) + + describe('browser namespace', () => { + const browser = useExtensionBrowser({ extensionName: 'rpc' }) + + it('aliases browser to the patched chrome object', async () => { + const backgroundPage = await waitForBackgroundPage(browser.extension, browser.session) + const result = await backgroundPage!.executeJavaScript( + `browser === chrome && typeof browser.browserAction.setBadgeText === 'function'`, + ) + expect(result).to.equal(true) + }) + }) }) diff --git a/packages/electron-chrome-extensions/src/renderer/index.ts b/packages/electron-chrome-extensions/src/renderer/index.ts index 78770e54..31aa0cd0 100644 --- a/packages/electron-chrome-extensions/src/renderer/index.ts +++ b/packages/electron-chrome-extensions/src/renderer/index.ts @@ -663,6 +663,18 @@ export const injectExtensionAPIs = () => { Object.freeze(chrome) + // Chromium also exposes a native `browser` namespace, separate from `chrome`. Point it at the + // patched `chrome` so extensions using `browser.*` (e.g. uBlock Origin, Plasmo) get the APIs + // above. defineProperty replaces the native global whether it's a value or an accessor. + if ('browser' in globalThis) { + Object.defineProperty(globalThis, 'browser', { + value: chrome, + enumerable: true, + configurable: true, + writable: true, + }) + } + void 0 // no return }