test: tabs.onUpdated

samuelmaddock · samuelmaddock · commit 1135fdd63d00 · 2025-05-17T11:55:07.000-04:00
diff --git a/packages/electron-chrome-extensions/spec/chrome-tabs-spec.ts b/packages/electron-chrome-extensions/spec/chrome-tabs-spec.ts
@@ -3,12 +3,22 @@ import { app, BrowserWindow } from 'electron'
 import { emittedOnce } from './events-helpers'
 
 import { useExtensionBrowser, useServer } from './hooks'
+import { ChromeExtensionImpl } from '../dist/types/browser/impl'
 
 describe('chrome.tabs', () => {
+  let assignTabDetails: ChromeExtensionImpl['assignTabDetails']
+
   const server = useServer()
   const browser = useExtensionBrowser({
     url: server.getUrl,
     extensionName: 'rpc',
+    assignTabDetails(details, tab) {
+      assignTabDetails?.(details, tab)
+    },
+  })
+
+  afterEach(() => {
+    assignTabDetails = undefined
   })
 
   describe('get()', () => {
@@ -265,4 +275,25 @@ describe('chrome.tabs', () => {
       expect(tabDetails.url).to.equal(secondTab.getURL())
     })
   })
+
+  describe('onUpdated', () => {
+    it('emits on "tab-updated" event', async () => {
+      const p = browser.crx.eventOnce('tabs.onUpdated')
+
+      // Wait for tabs.onUpdated listener to be set
+      await new Promise((resolve) => setTimeout(resolve, 10))
+
+      assignTabDetails = (details) => {
+        details.discarded = true
+      }
+
+      browser.webContents.emit('tab-updated')
+
+      const [_tabId, changeInfo, _tabDetails] = await p
+      expect(changeInfo).to.be.an('object')
+      expect(Object.keys(changeInfo)).to.have.lengthOf(1)
+      expect(changeInfo).to.haveOwnProperty('discarded')
+      expect(changeInfo.discarded).to.equal(true)
+    })
+  })
 })
diff --git a/packages/electron-chrome-extensions/spec/hooks.ts b/packages/electron-chrome-extensions/spec/hooks.ts
@@ -5,6 +5,7 @@ import { AddressInfo } from 'net'
 import { ElectronChromeExtensions } from '../'
 import { emittedOnce } from './events-helpers'
 import { addCrxPreload, createCrxSession, waitForBackgroundScriptEvaluated } from './crx-helpers'
+import { ChromeExtensionImpl } from '../dist/types/browser/impl'
 
 export const useServer = () => {
   const emptyPage = `<!DOCTYPE html>
@@ -49,6 +50,7 @@ export const useExtensionBrowser = (opts: {
   file?: string
   extensionName: string
   openDevTools?: boolean
+  assignTabDetails?: ChromeExtensionImpl['assignTabDetails']
 }) => {
   let w: Electron.BrowserWindow
   let extensions: ElectronChromeExtensions
@@ -72,6 +74,9 @@ export const useExtensionBrowser = (opts: {
         if (details.url) await tab.loadURL(details.url)
         return [tab, w!]
       },
+      assignTabDetails(details, tab) {
+        opts.assignTabDetails?.(details, tab)
+      },
     })
 
     extension = await customSession.loadExtension(path.join(fixtures, opts.extensionName))
