Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient lookups by stratifier/stratum #280

Open
timakro opened this issue Mar 24, 2025 · 2 comments
Open

Efficient lookups by stratifier/stratum #280

timakro opened this issue Mar 24, 2025 · 2 comments
Milestone

Comments

@timakro
Copy link
Collaborator

timakro commented Mar 24, 2025

The BBMRI Sample Locator is unresponsive when results are coming in due to how stratifier and stratum are looked up in getAggregatedPopulationForStratumCode. This should be made more efficient with hash maps.

@timakro
Copy link
Collaborator Author

timakro commented Mar 26, 2025

I had a discussion with @enola-dkfz and she suggested to transition to this format https://github.com/samply/prism/blob/main/resources/test/criteria_groups_bbmri.json for responses. If we were to implement that format we would get O(1) lookups by stratifier and stratum for free. @patrickskowronekdkfz also voiced interest moving away from the blaze response format to something simpler and independent from blaze.

@enola-dkfz
Copy link
Member

enola-dkfz commented Mar 26, 2025

Also, you might want Lens to get results in the same format regardless of the type of the store (especially when querying different types of stores at the same time, in order to not get many formats and have to add their differently formatted strata up).

If you decide on handling the Prism format I will extract the converter from MeasureReport to a separate Rust library to use in Focus as well.

Tagging @TKussel for a second (third, fourth) opinion.

@patrickskowronekdkfz patrickskowronekdkfz added this to the v0.5.1 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants