Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable search button when the user has entered text in the search bar #175

Open
enola-dkfz opened this issue Jan 20, 2025 · 1 comment · Fixed by #184
Milestone

Comments

@enola-dkfz
Copy link
Member

enola-dkfz commented Jan 20, 2025

General Summary

User can seemingly search for terms that are not in the criteria and get all the results (because no criteria are selected)

Expected Behavior

terms not found in the criteria should be deleted from the search bar

Current Behavior

terms not found in the criteria are left in the search bar and "Search" button is enabled

Possible Solution

Like, delete the term or something, JS allows it, but who knows with modern frameworks 😒

Steps to Reproduce

Type "turtle" in the search bar:

Image

Click anywhere:

Image

Click "Search" and get all the results:

Image

Context (Environment)

All projects, all environments

Detailed Description

No response

@enola-dkfz
Copy link
Member Author

Zdenka thinks the current situation is still confusing to the users and has a change request:
"When I search for non-sense I expect to not be able to click Search or I should receive error or flag... before empty search is started"
She mentioned she would expect the text to turn red, and the search button to be disabled.

@enola-dkfz enola-dkfz reopened this Mar 20, 2025
@timakro timakro removed their assignment Mar 24, 2025
@timakro timakro removed the bug Something isn't working label Mar 24, 2025
@timakro timakro changed the title [Bug]: Lens seemingly searches for nonsense Feature request: disable search button when the user has entered text in the search bar Mar 24, 2025
@patrickskowronekdkfz patrickskowronekdkfz added this to the v0.5.1 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants