Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

you ruined my hope #6

Open
numfin opened this issue Oct 15, 2020 · 4 comments
Open

you ruined my hope #6

numfin opened this issue Oct 15, 2020 · 4 comments

Comments

@numfin
Copy link

numfin commented Oct 15, 2020

i was searching for tree shakable faker. And found your package. You betrayed my hope bruv

@samir-araujo
Copy link
Owner

@numfin ! I'm terrible sorry to know this, but also somewhat happy to know that somebody else was interested in this little project of mine.

Your comment made my day, thus just let me know which methods you would like to see first and I will do my best to deliver them in the upcoming days 😄

@the0rem
Copy link

the0rem commented Jul 11, 2021

If this isn't tree-shakable as advertised, I would recommend not advertising it as such.

@samir-araujo
Copy link
Owner

If this isn't tree-shakable as advertised, I would recommend not advertising it as such.

Thanks for the feedback, @the0rem ! Could you please attach how you tested to see it is not tree-shakable, please?

@numfin
Copy link
Author

numfin commented Jul 18, 2021

@samir-araujo export default can't be tree-shakable by design. Try to use:
export { whatYouWantToReExport } from './path'
export * from './path'

you can test tree-shakability by building with rollup or other tree-shakfirstability bundlers and even make test that your tree-shakable library can tree-shake tree-shakable code. Good luck <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants