Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: truncate the hotkey name in case of a large memory footprint #26

Open
kirk91 opened this issue Jan 13, 2020 · 0 comments
Open

redis: truncate the hotkey name in case of a large memory footprint #26

kirk91 opened this issue Jan 13, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kirk91
Copy link
Member

kirk91 commented Jan 13, 2020

To avoid a large memory footprint, we should truncate the hotkey name. According to experience, 100 bytes should be enough.

More details see:

image

https://github.com/samaritan-proxy/samaritan/blob/master/proc/redis/filter_hotkey.go#L48

@kirk91 kirk91 added enhancement New feature or request good first issue Good for newcomers labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant