Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to get dependencies should fail the run #283

Open
rgarrigue opened this issue Mar 1, 2019 · 1 comment
Open

Failing to get dependencies should fail the run #283

rgarrigue opened this issue Mar 1, 2019 · 1 comment
Labels
bug
Milestone
Approved

Comments

@rgarrigue
Copy link

Hi

image

As shown above, getting this dependency failed (my bad, wrong token), but the test went on. Took me a while to figure out the reason, when it should have been obvious because failing straight away.
@gtmanfred gtmanfred added this to the Approved milestone Mar 1, 2019
@gtmanfred
Copy link
Contributor

bug, we should hard fail when a dependency cannot be found.

@gtmanfred gtmanfred added bug and removed enhancement labels Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@gtmanfred @rgarrigue