Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State postgres-reload-modules always reports changes #214

Open
Magomogo opened this issue May 22, 2018 · 0 comments
Open

State postgres-reload-modules always reports changes #214

Magomogo opened this issue May 22, 2018 · 0 comments

Comments

@Magomogo
Copy link

When a state does nothing it shouldn't report changes.
The issue caused by #188
@noelmcloughlin noelmcloughlin mentioned this issue Jun 6, 2018
Closed
alxwr added a commit to alxwr/postgres-formula that referenced this issue Apr 30, 2019
@alxwr
fix(postgres.manage): only reload modules if needed; fixes saltstack-…
ad6caee 
…formulas#214

Based on the great work of @RobRuana in saltstack-formulas#216.
alxwr added a commit to alxwr/postgres-formula that referenced this issue May 3, 2019
@alxwr
fix(postgres.manage): only reload modules if needed; fixes saltstack-…
feea4f1 
…formulas#214

Based on the great work of @RobRuana in saltstack-formulas#216.
jerrykan added a commit to jerrykan/postgres-formula that referenced this issue Sep 8, 2021
@jerrykan
fix(postgres.manage): only reload modules if needed (fix: saltstack-f…
59f7e16 
…ormulas#214)

We don't want the `postgres-reload-modules` state reporting any changes
to the user unless there is a need to reload the modules. We should only
need to reload the modules if the state that manages installing the
client libraries makes any changes (ie. new packages installed).

In turn, the states created by the `format_state` macro only need to
ensure that any module reload occurs before those states are applied. In
which case using a `require` makes more sense that using `onchanges`
(which may not be guaranteed to trigger).
@jerrykan jerrykan mentioned this issue Sep 8, 2021
Open
19 tasks
jerrykan added a commit to jerrykan/postgres-formula that referenced this issue Sep 23, 2021
@jerrykan
fix(postgres.manage): only reload modules if needed (fix: saltstack-f…
76fd3c7 
…ormulas#214)

We don't want the `postgres-reload-modules` state reporting any changes
to the user unless there is a need to reload the modules. We should only
need to reload the modules if the state that manages installing the
client libraries makes any changes (ie. new packages installed).

In turn, the states created by the `format_state` macro only need to
ensure that any module reload occurs before those states are applied. In
which case using a `require` makes more sense that using `onchanges`
(which may not be guaranteed to trigger).
jerrykan added a commit to jerrykan/postgres-formula that referenced this issue Mar 29, 2024
@jerrykan
fix(postgres.manage): only reload modules if needed (fix: saltstack-f…
823dde7 
…ormulas#214)

We don't want the `postgres-reload-modules` state reporting any changes
to the user unless there is a need to reload the modules. We should only
need to reload the modules if the state that manages installing the
client libraries makes any changes (ie. new packages installed).

In turn, the states created by the `format_state` macro only need to
ensure that any module reload occurs before those states are applied. In
which case using a `require` makes more sense that using `onchanges`
(which may not be guaranteed to trigger).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Magomogo