Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy keepalived config jinja #66

Open
kungfoome opened this issue May 24, 2017 · 1 comment
Open

copy keepalived config jinja #66

kungfoome opened this issue May 24, 2017 · 1 comment

Comments

@kungfoome
Copy link
Contributor

Would it be better to base the jinja template off the keepalived formula? https://github.com/saltstack-formulas/keepalived-formula/blob/master/keepalived/templates/config.jinja

It seems right now that all the options need to be maintained, but you can't easily add any if they are missing.

Problems may arise from certain settings with periods, which will probably need to be maintained. Example:

  • tune.ssl.maxrecord
  • tune.ssl.default-dh-param
  • tune.ssl.ssl-ctx-cache-size

Are there any foreseeable issues with doing it this way?

@johnkeates
Copy link
Contributor

While I agree that a programmatic expansion of a YAML tree into the HAProxy style config is preferred, I don't know (as you already suggest) what the impact would be on the output. We'd have to make some sort of CI check for this to see if all the config we want keeps working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants