Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] domain.sls should use the configured cli client #28

Open
Cybso opened this issue Dec 7, 2023 · 0 comments
Open

[BUG] domain.sls should use the configured cli client #28

Cybso opened this issue Dec 7, 2023 · 0 comments

Comments

@Cybso
Copy link

Cybso commented Dec 7, 2023

The certbot binary in letsencrypt/client/domain.sls is hardcoded but should use the configured cli binary instead. The patch is a one-liner, so please excuse me for keeping this bugreport compact and not making an elaborate pull request for it :-)

diff --git a/letsencrypt/client/domain.sls b/letsencrypt/client/domain.sls
index b7ab774..cab7b38 100644
--- a/letsencrypt/client/domain.sls
+++ b/letsencrypt/client/domain.sls
@@ -23,7 +23,7 @@
 certbot_{{ domain }}:
   cmd.run:
     - name: >
-        certbot certonly {{ staging }} --non-interactive --agree-tos --no-self-upgrade --email {{ params.email|default(client.email) }}
+        {{ client.source.cli }} certonly {{ staging }} --non-interactive --agree-tos --no-self-upgrade --email {{ params.email|default(client.email) }}
         {%- if auth.method == 'standalone' %}
         --standalone --preferred-challenges {{ auth.type }} --http-01-port {{ auth.port }}
         {%- elif auth.method == 'webroot' %}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant