Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy support #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added proxy support #38

wants to merge 1 commit into from

Conversation

cznewt
Copy link
Member

@cznewt cznewt commented Jun 6, 2018

No description provided.

Copy link
Member

@epcim epcim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly agree, but not sure why plugins section was removed

Missing update in tests/pillar/* so it's going to be tested

@@ -87,11 +87,6 @@ Simple master with reverse proxy
regex: "contrail-build-.*"
- name: "Aptly"
regex: "aptly-.*"
plugins:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugins don't work this way, why they were removed form example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants