Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class embeddings to GVE ? #6

Open
saurabhsharma1993 opened this issue Oct 18, 2018 · 1 comment
Open

Class embeddings to GVE ? #6

saurabhsharma1993 opened this issue Oct 18, 2018 · 1 comment

Comments

@saurabhsharma1993
Copy link

Hi,
In the GVE paper, the LRCN is modified so that class embeddings are passed at every time step to the second LSTM. I see that you are appending the one-hot class labels to the image features. This is different from the paper, which uses class embeddings comptued from average hidden state for a language model trained on the image features. You should correct this.

@salaniz
Copy link
Owner

salaniz commented Oct 22, 2018

It works well enough with one-hot class embeddings. If you want this implementation to learn/support LSTM class embeddings, feel free to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants