Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings when compiling in windows #75

Open
jpujol opened this issue Nov 23, 2018 · 2 comments
Open

warnings when compiling in windows #75

jpujol opened this issue Nov 23, 2018 · 2 comments

Comments

@jpujol
Copy link

jpujol commented Nov 23, 2018

I am compiling in Windows (VS2017) and I am getting warnings like

tmxpropertyset.h(66): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data

Basically it shows a warning for all the functions that return size of a stl container, since the return value is cast to an int. Technically, size() returns a size_type.

I was going to create a PR changing all the interfaces that get the size of a container to return a size_type, but I wanted to ask for your opinion first, @sainteos

@sainteos
Copy link
Owner

Yeah, that change seems to make sense. If you still want to do this (sorry for the wildly late reply), go for it. If not, I can.

@jpujol
Copy link
Author

jpujol commented Nov 14, 2019

oh, I can do it! thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants