Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos check into ci workflow #1024

Open
ben1009 opened this issue Jan 16, 2024 · 2 comments
Open

Add typos check into ci workflow #1024

ben1009 opened this issue Jan 16, 2024 · 2 comments

Comments

@ben1009
Copy link
Contributor

ben1009 commented Jan 16, 2024

Feature Description

Automatic the typos check into ci workflow check, instead of manually run the check

Describe The Solution You'd Like

Code Sample

/// paste code here
@sagiegurari
Copy link
Owner

yap, i was thinking about it after you ran it for me.
how about a PR? it should be toml changes only.
just make sure to make it optional and 'off' by default via env param like other things since i don't want to break everyones CI suddenly.

@ben1009
Copy link
Contributor Author

ben1009 commented Jan 17, 2024

yap, i was thinking about it after you ran it for me. how about a PR? it should be toml changes only. just make sure to make it optional and 'off' by default via env param like other things since i don't want to break everyones CI suddenly.

sure, i will make the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants