Skip to content

Run pytest again on CI #40446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

tobiasdiez
Copy link
Contributor

Pytest used to run on CI, but this is no longer the case. Here, we reactivate it by removing some safe-guards that are no longer necessary as pytest is a standard package now.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tobiasdiez
Copy link
Contributor Author

No idea about the failing tests in test-long....

@orlitzky
Copy link
Contributor

I guess the CI is invoking pytest via the ./sage script and a doctest wrapper? I was just typing pytest like a crazy person.

@tobiasdiez
Copy link
Contributor Author

I guess the CI is invoking pytest via the ./sage script and a doctest wrapper? I was just typing pytest like a crazy person.

Yes, pytest is called as part of sage -t (that was supposed to work already). I don't get the test failures in dev_tools.py - they seem to be unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants