Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter endpoints not returning DATE_LABELs #659

Open
iamacook opened this issue Sep 20, 2022 · 1 comment
Open

Filter endpoints not returning DATE_LABELs #659

iamacook opened this issue Sep 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

Describe the bug
The following endpoints only return TRANSACTION elements:

  • /v1/chains/{chainId}/safes/{address}/incoming-transfers/
  • /v1/chains/{chainId}/safes/{address}/module-transactions/
  • /v1/chains/{chainId}/safes/{address}/multisig-transactions/

As they are all 'historical' transactions, they should match that of the /v1/chains/{chainId}/safes/{safe_address}/transactions/history endpoint and return DATE_LABELs nested between differing days (relevant to the timezone_offset, see #660.

To Reproduce
Steps to reproduce the behavior:

  • Call each of the endpoints with a filter query and observe that no DATE_LABEL elements are present.

Expected behavior

  • A list of TRANSACTION elements matching that of the desired filter with DATE_LABEL elements between those on different days (relevant to the provided timezone_offset). (Example client side implementation (that was removed) can be found here)

Environment (please complete the following information):

  • Staging and production
  • All chains
@iamacook iamacook added the bug Something isn't working label Sep 20, 2022
@fmrsabino
Copy link
Contributor

After aligning internally, we will tackle this issue in https://github.com/5afe/safe-client-gateway-nest

@fmrsabino fmrsabino transferred this issue from 5afe/safe-client-gateway Aug 28, 2023
@PooyaRaki PooyaRaki added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants