-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot find my spec file #40
Comments
I cannot understand what is going on. in the first part of the grading ie default profile & why I loose 20 marks. On my Local machine everytimg passes. In fact I have tried many ways to get this home work to pass it is very specific regarding rspec but this seems like a cucumber issue but later by disabling the profiles it all passes. I did alter web_steps.rb but have reverted this to default
|
just a guess @Russell108 - is it possible that your cucumber setup is not configured properly for coverage? I'm just looking at the following output:
seems like the zero cucumber scenarios running as part of the coverage report might be the problem? although conceivably it's the rspec coverage configuration - do you get a coverage report running locally? |
Thanks for the email Sam
Yes also if you look further down It does pass the cucumber tests later on in the grading I get 80% as a final mark at the moment
I am using the factory girl gem.
What I did do is find someone elses work where they passed cucumber but had not done the rsopec stuff
I put this into the grader and the first part passed
Locally it all passes I have tried many scenarios but yet to find one which passes the grader with 100% I
Now wonder wether its worth the effort.
I am now testing in my development projects I am actually using the built in rails tests
I I must say I loved the course apart form some of the quarks in the graders but hey thats life.
The course really added a lot to my life in terms of concepts and new ways of thinking.
I don’t know what the default profile is is that my default profile to the graders?
I am on a Mac by the way.
I guess I will have to try again from scratch which I already done a few times
Thank you
… On 29 Oct 2018, at 10:54, Sam Joseph ***@***.***> wrote:
just a guess @Russell108 <https://github.com/Russell108> - is it possible that your cucumber setup is not configured properly for coverage?
I'm just looking at the following output:
Running student tests found in features/ spec/:
Using the default profile...
0 scenarios
0 steps
0m0.000s
Coverage report generated for Cucumber Features to /home/ubuntu/rag/submissions/dfaba4421e72798c347dbec8233e880c/assignment4/2018-10-26-11-14-47/coverage. 0.0 / 0.0 LOC (100.0%) covered.
Cucumber: 0 out of 0 scenarios passed
RSpec: 18 out of 18 tests passed
Score: 20/40
seems like the zero cucumber scenarios running as part of the coverage report might be the problem? although conceivably it's the rspec coverage configuration - do you get a coverage report running locally?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAmF757d5sj_LhefSOBO341pYJS1EgiTks5upt54gaJpZM4X7-iE>.
|
hi @Russell108 - yes, I see you have the cukes - what I mean is that the cukes may not be "hooked up" to the coverage via the env.rb file. See the instructions in part 2 where it says:
I was wondering if that might be the problem. The graders a flaky - we do have an upgrade for this whole assignment that should make it less flaky but haven't had time to deploy yet. I've been working with the graders for five years, and I am not sure what the default profile is - I could come up with a guess by diving into them, but as you say, probably not worth it. I wouldn't bother starting from scratch, just making sure you can get simple cov results locally for both cukes and rspec. |
Hi Sam
I just deleted the contents of coverage folder & ran cucumber with out rspec
Stats as follows
But I I run rspec the coverage is as follows
Strange
… On 30 Oct 2018, at 09:47, Sam Joseph ***@***.***> wrote:
hi @Russell108 <https://github.com/Russell108> - yes, I see you have the cukes - what I mean is that the cukes may not be "hooked up" to the coverage via the env.rb file. See the instructions in part 2 <https://github.com/saasbook/hw-acceptance-unit-test-cycle> where it says:
Next, add the following code BEFORE ANYTHING ELSE ON LINE ONE of spec/rails_helper.rb and features/support/env.rb:
require 'simplecov'
SimpleCov.start 'rails'
I was wondering if that might be the problem.
The graders a flaky - we do have an upgrade for this whole assignment that should make it less flaky but haven't had time to deploy yet.
I've been working with the graders for five years, and I am not sure what the default profile is - I could come up with a guess by diving into them, but as you say, probably not worth it.
I wouldn't bother starting from scratch, just making sure you can get simple cov results locally for both cukes and rspec.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAmF71O32SAq4OsBBWVpnwTf6nsQ5o4fks5uqCAngaJpZM4X7-iE>.
|
@Russell108 I think you are missing things from ^^^ you can edit the comment |
Emm
Sorry you lost me here
I don’t understand your last email?
Thank you Russell
… On 30 Oct 2018, at 11:13, Sam Joseph ***@***.***> wrote:
@Russell108 <https://github.com/Russell108> I think you are missing things from ^^^ you can edit the comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAmF7ya95MbHFcpGZ6IFYIw8d-Kk7RUiks5uqDRSgaJpZM4X7-iE>.
|
@Russell108 look at your comment from before. this is what it looks like to me: it looks like you were trying to paste in some terminal output, but failed to do so - please edit the comment to include the output you wanted |
I had the exact same problem. I solved it by deleting the P.S. You see where it says |
No description provided.
The text was updated successfully, but these errors were encountered: