zip files that cause grader exceptions #23
Comments
|
ARCHIVE_HIDDEN |
|
ARCHIVE_HIDDEN |
|
@bill-auger Do you by any chance know, if anyone from 2016 has gotten 100/100 for HW5 so far? |
|
@HusainJaffer i think there maybe something buggy with the grader for this assignment - i was able to get 100% but i had to do something very naughty - #24 is a discussion about it |
|
student weiherj archive ARCHIVE_HIDDEN |
|
@bill-auger I was thinking of maybe blocking cucumber from loading in the .rb files in features/spec directory,and I also changed the homepage path to '/movies' |
|
ARCHIVE_HIDDEN |
|
ARCHIVE_HIDDEN |
|
ARCHIVE_HIDDEN My autograder output. |
|
@anklinuxboy I'm seeing this error for your code when I run against the grader locally: looks like you have multiple migrations |
|
@HusainJaffer Running locally I see this error for the your zip file: |
|
@HusainJaffer, @gpincheiraa, @weiherj, @alireza-a, @anklinuxboy - I'd encourage you to all re-submit - I've just updated the grader to provide more details feedback on the issues you've been encountering. Please also do ensure that everything runs for you locally before you submit to the autograder. Looking at some of these errors it seems like they should have been showing up for you on your local machines or C9. |
|
@tansaku Thanks. I was sured that my homework in my local machine works. rspec passing all the tests and cucumber scenarios too. |
|
@tansaku Thanks. The added feedback from the autograder was very helpful. I found my issue and fixed it. |
|
do the tests depend on a specific version of "rspec-rails" ? |
|
I have a strange one that I managed to fix on my own. Here's what I saw from my first submission:
By changing the failing rspec example (which was fine as-is on C9) to use BTW, my coverage report on C9 says 100%, which I did not achieve with the autograder (but I got enough credit to get full points). If it would be useful for me to post my zip files (failing and/or not failing, with or without coverage directory) here, just let me know. |
|
I cannot submit hw5.zip I get the following error when clicking "Check": However I was able to submit it first time (I got a lot of errors although everything was passing in my c9) |
|
I (Norm Meyer) also had a completely successful rspec and cucumber output on cloud 9 but had failures on the grader. There also seems to be some coverage issues with the grader. I did everything in the assignment, the only uncovered area was a few lines of the MoviesController index method, which was outside of the scope of the assignment. I only received 40/100 pts. but have successfully completed all parts (or at least a much larger portion than 40%). autograder output: ARCHIVE_HIDDEN\ |
|
@jcbc98 thanks for the additional feedback - it would be very helpful if you could post your zip file here as it's difficult to process your feedback effectively without it - many thanks in advance ... |
|
@alireza-a - that's a good question about a dependency on a version of rspec-rails. It's possible. In this assignment you are submitting parts of an app and they are being merged into another app for the grader to operate. |
|
I am having problems with the scenarios to sort movies alphabetically and by release date - in both cases, the output from the scenario looks like this: ARCHIVE_HIDDEN The relevant code in movie_steps.rb is: These tests pass without any problem when I run them locally and I don't understand why they would be failing remotely because I am supplying the view that contains the table whose rows are counted. (Incidentally, I originally used |
|
@RobertStroud - thanks for submitting this - I've been investigating and so far cannot see why the grader does not like this. In the short term I recommend switching your step to something else like: Then /I should see all the movies/ do
# Make sure that all the movies in the app are visible in the table
Movie.all.each do |m|
expect(page).to have_content m.title
end
endIt's not as pure an acceptance test, but I think it might work for you in this case. It's a glass box test where we are allowing ourselves privileged access to the database - not ideal for an acceptance test, but probably a reasonable step to get you out of your current fix ... |
|
@tansaku - thanks. That did the trick. I'm now getting 100% for the coursework... 👍 |
|
My first submission: My final submission (includes the coverage directory): |
|
@at first I was having issues with the sad path and test coverage. After trying to debug those problems, the grader is complaining about this problem. I'm not getting this error on Cloud9. ARCHIVE_HIDDEN |
|
@zarak have replicated locally - this might help: Looking at your code I see you do have your factory defined twice: [tansaku@Samuels-MBP:~/Documents/GitHub/saasbook/rag/submissions/506af89a6181960fc69f47f1fbc8d708/assignment4/2016-07-19-10-32-57 (103_tr_count_issue)]$
→ more spec/factories.rb
FactoryGirl.define do
factory :movie do
title "Star Wars"
rating "PG"
release_date { 10.years.ago }
director "George Lucas"
end
end
[tansaku@Samuels-MBP:~/Documents/GitHub/saasbook/rag/submissions/506af89a6181960fc69f47f1fbc8d708/assignment4/2016-07-19-10-32-57 (103_tr_count_issue)]$
→ more spec/factories/movie.rb
FactoryGirl.define do
factory :movie do
title "Star Wars"
rating "PG"
director "George Lucas"
release_date { 10.years.ago }
end
endnot sure why that's not giving you a problem on C9, but is an issue that needs fixing ... try removing one or other of those files and re-submitting |
|
@enkaba are you sorted now? see this thread for help if not: https://courses.edx.org/courses/course-v1:BerkeleyX+CS169.1x+3T2015SP/discussion/forum/i4x-edx-templates-course-Empty/threads/578b1e09af36f3051300031c @nbartowski are you still stuck? I'm just going to investigate your issue, as I think it's the last blocker outstanding on this thread ... |
|
@nbartowski I think this might be the issue, the grade runs an additional migration that inserts a load of movies into the database for testing: class AddMoreMovies < ActiveRecord::Migration
MORE_MOVIES = [
{:title => 'Aladdin', :rating => 'G', :release_date => '25-Nov-1992'},
{:title => 'The Terminator', :rating => 'R', :release_date => '26-Oct-1984'},
{:title => 'When Harry Met Sally', :rating => 'R', :release_date => '21-Jul-1989'},
{:title => 'The Help', :rating => 'PG-13', :release_date => '10-Aug-2011'},
{:title => 'Chocolat', :rating => 'PG-13', :release_date => '5-Jan-2001'},
{:title => 'Amelie', :rating => 'R', :release_date => '25-Apr-2001'},
{:title => '2001: A Space Odyssey', :rating => 'G', :release_date => '6-Apr-1968'},
{:title => 'The Incredibles', :rating => 'PG', :release_date => '5-Nov-2004'},
{:title => 'Raiders of the Lost Ark', :rating => 'PG', :release_date => '12-Jun-1981'},
{:title => 'Chicken Run', :rating => 'G', :release_date => '21-Jun-2000'},
]
def up
MORE_MOVIES.each do |movie|
Movie.create!(movie)
end
end
def down
MORE_MOVIES.each do |movie|
Movie.find_by_title_and_rating(movie[:title], movie[:rating]).destroy
end
end
endIt's not good practice and I can't immediately change it, but possibly this information can allow you to adjust your test to avoid colliding with it ... |
|
@RobertStroud I think the comment above ^^^ also explains why you saw the 20 rows rather than the 10 ... |
|
@tansaku Thanks very much for looking into this. I did have duplicate definitions at one point, but then I deleted them. I exhaustively searched my project directory on cloud9 for duplicate definitions using |
|
@zarak - not a problem - I think the thing is that when you re-zip with the same name it doesn't delete the older files in the zip - I think that's been the source of several problems. It's probably good practice to delete old zip files, or at least delete them when there's anything odd going on :-) |
|
@tansaku Oh yes, that was it then. It should have tipped me off when the zip operation said @nbartowski I had the same issue with |
|
@tansaku - thanks. I agree that this looks like the reason I saw 20 rows rather than 10 rows. But that raises the issue of how best to write the unit test if you don't know how many movies there are, or if the auto grader adds some extra movies that you don't know about. You said that the approach you suggested earlier (iterating over the Movies object) was not pure as an acceptance test, so what would be the cleanest solution? -----Original Message----- @RobertStroud I think the comment above ^^^ also explains why you saw the 20 rows rather than the 10 ... |
|
@tansaku Yes, thanks. It was a problem with file size. |
|
@tansaku - thanks. Your info above helped. I had defined the :id for my FactoryGirl movie as '1'. This was in conflict because the autograder already had a movie record with id of '1'. I changed the :id = '47' and everything work. Thanks a ton for the help. One comment, but please don't spend time replying - you've already spent significant time helping and this is not that important, this is just feedback for future offerings of the course- I lost 20 pts because my controller coverage was too low (88.89%; I think you required 90%). When I looked at my coverage, the only lines not included were a few in the index method, which I didn't write (i.e. I downloaded the class version of the homework from github). I was under the impression from the directions that we didn't need to write tests for the index method, and I didn't as this assignment ended up taking significantly more time than the previous four and I couldn't afford anymore time. So my suggestion I guess is either: lower the percentage coverage required for the controller in future offerings or include the index method in the list of additional methods to write unit tests for in the instructions. Also, it looked like you either got all 20 pts or none at all. Maybe there could be a formula for how many pts one gets, as I wrote unit tests for create, update, destroy, and the new method to find movies with the same director. I'm not worried about my score, so no need to do anything now, this is just feedback Thanks again to you and the other TA's for all the hardwork. Overall, this was an excellent course and I learned a lot of valuable info. I'm looking forward to the next class in september! |
|
@zarak thanks for the feedback! |
|
ARCHIVE_HIDDEN I have passed all tests and scenarios on C9 environment, but when I upload this file, it says that Cucumber tests run fine, but almost none of the RSpecs. Here's what the autograder says: |
|
thanks for submitting this @siderio2 - sorry I couldn't review before the deadline - need to focus on peer reviews now I'm afraid - will try and come back to this when I can - I get the sense that this won't have prevented you from getting a certificate ...? |
|
Hello, Sam.Nope, no problem with the certificate. It's just that I want to understand what I did wrong. So when you have some time to spend on it, I would really appreciate if we can get an answer, but doesn't mind if it's tomorrow or next week.Congrats for the great work you and your partners are doing, excelent course, really. ________________________Desiderio Martínez Silva thanks for submitting this @siderio2 - sorry I couldn't review before the deadline - need to focus on peer reviews now I'm afraid - will try and come back to this when I can - I get the sense that this won't have prevented you from getting a certificate ...?— |
|
Hi @bill-auger I and other 2 persons are having bundle grading issues. So could you help us please! reference: Also the course page says the files should be within a 'hw5' directory and the corresponding repo readme states that the files should be within a 'rottenpotatoes' directory.
ARCHIVE_HIDDEN |
|
what exactly is the error? is it like any of the others mentioned in this thread? if not then could you post the entire grader output here or in a pastbin? regarding the folder name it should certainly be 'rottenpotatoes' as it exists in this repo - some time ago the directory was named 'hw5' - i remember writing the patch to the README then - if he courseware page says 'hw5' then it must need updating https://github.com/saasbook/hw-acceptance-unit-test-cycle/pull/19/files |
|
just FYI to anyone new with admin access here - where ever you see "ARCHIVE_HIDDEN" there is a hidden homework submission - you would need to click the pencil button to edit the comment in order to access the file - this is becuase edX does not allow posting of complete homework assignment publicly so we hide them manually in this way |
|
@bill-auger - This is the complete message: |
|
Hi @bill-auger any news on the above bundle error? |
|
oh sry - i am not actually signed up for the class this time - i have been a TA for this course for a long time so i knew this issue well - i still get alerts on it though and thought i would help triage but i was expecting someone else would investigate it beyond that i just sent a message on the auto-graders channel so the admins may have a look at this |
|
@efiguerc I was working on this issue yesterday and may have fixed it - give it another try |
if the auto-grader is giving errors for your HW5 submission please drag and drop your zip file into a comment below
HusainJaffer, gpincheiraa, weiherj, nbartowski, siderio2 files result in this error:
nbartowski and zarak seem to have hit the perennial factory girl issue
nbartowski's file gives
zarak's file gives
i have not investigated any of these yet
The text was updated successfully, but these errors were encountered: