Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: themes that change the default font conflicts with the ones that does not. #3272

Open
dlgiovani opened this issue Nov 11, 2024 · 1 comment
Labels

Comments

@dlgiovani
Copy link

dlgiovani commented Nov 11, 2024

What version of daisyUI are you using?

v4.12.14

Which browsers are you seeing the problem on?

Chrome

Reproduction URL

https://play.tailwindcss.com/lRO0Xn8ZBy

Describe your issue

Problem:

Themes such as wireframe that changes the default font will also change the font of children elements that have another data-theme that does not changes the default font.

For example, if you have this:

<div data-theme="wireframe">
  <p>Hello</p>
  <!-- this font will be serif, as expected from the theme "wireframe" -->

  <p data-theme="dark">World</p>
  <!-- this font will ALSO be serif, which is not expected for the theme "dark" -->
</div>

This seems to only occur when the parent data-theme has an explicit change to the default font, in other words, having a dark themed parent won't affect the wireframe themed children.

Copy link

Thank you @dlgiovani for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi saadeghi added the v5 label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants