Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

swagger-ui from a folder instead of zip #55

Open
ugupta opened this issue Oct 28, 2013 · 2 comments
Open

swagger-ui from a folder instead of zip #55

ugupta opened this issue Oct 28, 2013 · 2 comments

Comments

@ugupta
Copy link

ugupta commented Oct 28, 2013

I am not sure why we would want to keep the swagger-ui as a zip file while you can simply handle it as a folder under resource.

binary (zip) requires special handling and there is no need to put files as zip in git as the compression is already applied by git. It will just waste space and make your deltas larger and larger.

If you provide a folder approach then I can maintain my version of swagger-ui as a folder instead of a zip file.

Please let us know if you are doing any special handling or just for the sake of compression you are putting swagger-ui in a zip file.

I would be happy to work on a patch for this but I would like to know before hand if that would be considered.

@ryankennedy
Copy link
Owner

It's not the compression benefit I was after originally. More the desire to download the ZIP file, toss it in my resources directory, and call it a day. I think it would be fine to be able to specify either a ZIP or a directory and have the code do the right thing.

@conorroche
Copy link

ive added support for this in my fork https://github.com/Carma-Public/swagger-jaxrs-doclet via the swaggerUiPath doclet option

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants