Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default response validation neglects checking status code #14

Open
hatalyakgyula opened this issue May 17, 2024 · 0 comments
Open

Default response validation neglects checking status code #14

hatalyakgyula opened this issue May 17, 2024 · 0 comments

Comments

@hatalyakgyula
Copy link

This is a conceptual issue or an enhancement request addressing the following case.
Assume we are using the default configuration and there is no captive portal present. If the server successfully returns a response with some unexpected content that does not contain "Success" as a substring Hyperconnectivity will consider the response as a failed one despite of being successful. In general should we consider having successful responses as a connected state regardless of status code and content if there is no captive portal present?
I think it is worth considering to add checks about the response's status code here. If we should consider other (status code,response data) pairs than the (200,expected-string) as acceptable, searching for the expected string should be dependent on status code.
Would you consider refining the default behaviour in that way if it makes sense to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant