Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] deltaBottom is not calculated correctly in horizontal view #35

Open
AlexanderFarkas opened this issue Jun 8, 2021 · 2 comments
Open

Comments

@AlexanderFarkas
Copy link

Element is SizedBox(width: 20, height: 60)
InviewList is horizontal (Axis.horizontal)

In 'isInViewPortCondition' I still receive such calculations:
final width = deltaTop - deltaBottom. (60)
But it should be 20.

deltaTop is calculated correctly, but deltaBottom is not, because it takes item's height, not width.

@AlexanderFarkas AlexanderFarkas changed the title [Bug] deltaTop and deltaBottom are not calculated correctly in horizontal view [Bug] deltaBottom is not calculated correctly in horizontal view Jun 8, 2021
@AlexanderFarkas
Copy link
Author

AlexanderFarkas commented Jun 8, 2021

@rvamsikrishna Wrong part is here
It should be something like 'orientation == Axis.vertical ? size.height : size.width'

@AlexanderFarkas
Copy link
Author

AlexanderFarkas commented Jun 9, 2021

#37 @rvamsikrishna Fixed here.
Please, review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant