Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨ FEATURE]: add translations for heuristic test #433

Closed
FernandaCasali opened this issue Apr 15, 2024 · 15 comments
Closed

[✨ FEATURE]: add translations for heuristic test #433

FernandaCasali opened this issue Apr 15, 2024 · 15 comments
Assignees
Labels
doing This issue is being done by somebody

Comments

@FernandaCasali
Copy link
Member

Feature Description πŸ“

Add i18n translation for all languages in heuristic test.
Especially files:

  • WeightTable
  • OptionsTable
  • HeuristicsTesteAnswer
  • HeuristicsSettings
  • EditHeuristicsTest

Motivation 🌟

.

Expected Behavior πŸ€”

.

Additional Information ℹ️

.

@FernandaCasali FernandaCasali added the Enhancement New feature or request label Apr 15, 2024
@KarinePistili KarinePistili added the Help wanted Extra attention is needed label Apr 15, 2024
@BasmaElhoseny01
Copy link
Collaborator

I can do this @KarinePistili

@SujashB
Copy link

SujashB commented Apr 15, 2024

I am willing to do this! I have experience in Javascript and I also made a PR in eye-tracker-front

@KarinePistili
Copy link
Member

Assigned to @BasmaElhoseny01 as it was the first comment.

If you have any questions, ping us here ;)

@KarinePistili KarinePistili added doing This issue is being done by somebody and removed Enhancement New feature or request Help wanted Extra attention is needed labels Apr 15, 2024
@BasmaElhoseny01
Copy link
Collaborator

BasmaElhoseny01 commented Apr 16, 2024

Assigned to @BasmaElhoseny01 as it was the first comment.

If you have any questions, ping us here ;)

I have checked out the code and found json files for 4 languages are already implemented just to check it is required to just add json files for other languages ?(just static translated files or dynamic translation on run )

Another point it is mentioned in the issue that all languages are required which isn't doable manually
So the question is it required to just be adding json files or want like live streaming translation using api like Google translate
@KarinePistili

@BasmaElhoseny01
Copy link
Collaborator

Assigned to @BasmaElhoseny01 as it was the first comment.

If you have any questions, ping us here ;)

I have checked out the code and found json files for 4 languages are already implemented just to check it is required to just add json files for other languages ?(just static translated files or dynamic translation on run )

Another point it is mentioned in the issue that all languages are required which isn't doable manually
So the question is it required to just be adding json files or want like live streaming translation using api like Google translate
@KarinePistili
I think you expect this to be done as sw solution not AI (not using models for each language) just confirm

@asr2003
Copy link

asr2003 commented Apr 17, 2024

@BasmaElhoseny01 I think it is better to go with json files instead translation api's

@BasmaElhoseny01
Copy link
Collaborator

BasmaElhoseny01 commented Apr 17, 2024

@BasmaElhoseny01 I think it is better to go with json files instead translation api's

Then I think we need to specify the languages not all languages @asr2003

@KarinePistili
Copy link
Member

Hello @BasmaElhoseny01 !! It is not all languages in the world, just the ones we already have the json files within the code --(English, Spanish, Hindi and Portuguese (Brazil)--

The main idea of this issue is that we can replace the hardcoded english strings from the places @FernandaCasali mentioned so they are also included within the i18n system.

We need the strings at least placed on all json files that exists so everything works correclty. You can use google translate or anything you like to create these key-values in the jsons. If you think those 4 are still too much to translate, we can split this issue in two:

  • You update the hardcoded strings to use i18n, then add the strings for English and leave the other languages with the strings empty
  • other person (we would open other issue) translate those strings for the languages missing, so it would be just translating thing as it would be already present correclty in the code

What do you prefer to do @BasmaElhoseny01 ?

Option 1: do it all for the languages we have
Option 2: split into two issues and you do the first one?

image

@BasmaElhoseny01
Copy link
Collaborator

Hello @BasmaElhoseny01 !! It is not all languages in the world, just the ones we already have the json files within the code --(English, Spanish, Hindi and Portuguese (Brazil)--

The main idea of this issue is that we can replace the hardcoded english strings from the places @FernandaCasali mentioned so they are also included within the i18n system.

We need the strings at least placed on all json files that exists so everything works correclty. You can use google translate or anything you like to create these key-values in the jsons. If you think those 4 are still too much to translate, we can split this issue in two:

  • You update the hardcoded strings to use i18n, then add the strings for English and leave the other languages with the strings empty

  • other person (we would open other issue) translate those strings for the languages missing, so it would be just translating thing as it would be already present correclty in the code

What do you prefer to do @BasmaElhoseny01 ?

Option 1: do it all for the languages we have

Option 2: split into two issues and you do the first one?

image

Fine I think it is better to have it split into 2 issues but let me first check if I can make script for translation for the English json file to other languages so no need for manual translation . But I need to verify if there is free api for such case. I will check it out and reply. If not feasible we will need to open new issue for the translation so that others can contribute and learn 😊

@KarinePistili
Copy link
Member

Great! I'll wait for your answer

@BasmaElhoseny01
Copy link
Collaborator

BasmaElhoseny01 commented Apr 18, 2024

@KarinePistili @FernandaCasali plz check the following commits and tell me if code format and how are keys placed at the json is files are fine with your gernal structure so that i can complate other pages
BasmaElhoseny01@3319b47
BasmaElhoseny01@f619f87
Notice I have added like teample for each page i do in the local langugae josn file

@KarinePistili
Copy link
Member

hi @BasmaElhoseny01 , it is perfect you can follow up like this. Thanks

@BasmaElhoseny01
Copy link
Collaborator

@KarinePistili @FernandaCasali https://github.com/BasmaElhoseny01/RUXAILAB/blob/84dde38b07edfc39fb68c36aaa1f77f21f6fe696/src/utils/headers.js#L1-L7 this ibjects will no longer be used because we need to access the i18n moduel which is specific per component so i need t copy this to be inside the component it self confirm plz if you have any problem

note: i won't modify any thing in the file headers.js because it may be used by others :D

@KarinePistili
Copy link
Member

Hello @BasmaElhoseny01 , yes you can do it like that it is okay

@saltykheera
Copy link
Contributor

@KarinePistili this issue is completed close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing This issue is being done by somebody
Projects
None yet
Development

No branches or pull requests

6 participants