-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[β¨ FEATURE]: add translations for heuristic test #433
Comments
I can do this @KarinePistili |
I am willing to do this! I have experience in Javascript and I also made a PR in eye-tracker-front |
Assigned to @BasmaElhoseny01 as it was the first comment. If you have any questions, ping us here ;) |
I have checked out the code and found json files for 4 languages are already implemented just to check it is required to just add json files for other languages ?(just static translated files or dynamic translation on run ) Another point it is mentioned in the issue that all languages are required which isn't doable manually |
|
@BasmaElhoseny01 I think it is better to go with json files instead translation api's |
Then I think we need to specify the languages not all languages @asr2003 |
Hello @BasmaElhoseny01 !! It is not all languages in the world, just the ones we already have the json files within the code --(English, Spanish, Hindi and Portuguese (Brazil)-- The main idea of this issue is that we can replace the hardcoded english strings from the places @FernandaCasali mentioned so they are also included within the i18n system. We need the strings at least placed on all json files that exists so everything works correclty. You can use google translate or anything you like to create these key-values in the jsons. If you think those 4 are still too much to translate, we can split this issue in two:
What do you prefer to do @BasmaElhoseny01 ? Option 1: do it all for the languages we have |
Fine I think it is better to have it split into 2 issues but let me first check if I can make script for translation for the English json file to other languages so no need for manual translation . But I need to verify if there is free api for such case. I will check it out and reply. If not feasible we will need to open new issue for the translation so that others can contribute and learn π |
Great! I'll wait for your answer |
@KarinePistili @FernandaCasali plz check the following commits and tell me if code format and how are keys placed at the json is files are fine with your gernal structure so that i can complate other pages |
hi @BasmaElhoseny01 , it is perfect you can follow up like this. Thanks |
@KarinePistili @FernandaCasali https://github.com/BasmaElhoseny01/RUXAILAB/blob/84dde38b07edfc39fb68c36aaa1f77f21f6fe696/src/utils/headers.js#L1-L7 this ibjects will no longer be used because we need to access the i18n moduel which is specific per component so i need t copy this to be inside the component it self confirm plz if you have any problem note: i won't modify any thing in the file headers.js because it may be used by others :D |
Hello @BasmaElhoseny01 , yes you can do it like that it is okay |
@KarinePistili this issue is completed close this issue |
Feature Description π
Add i18n translation for all languages in heuristic test.
Especially files:
Motivation π
.
Expected Behavior π€
.
Additional Information βΉοΈ
.
The text was updated successfully, but these errors were encountered: