You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@daxpedda do you have permissions to make a release? I was thinking of setting up a GitHub actions workflow for it, but I don't have the permissions on crates.io and a secret needs be added before publishing can be done
Activity
daxpedda commentedon Jul 20, 2023
I would have liked to fix #3483 first, but unfortunately we don't seem to have the time.
@stephanemagnenat if you replicate #3475 it would help to get a release now instead of later.
stephanemagnenat commentedon Jul 21, 2023
@daxpedda thanks for the fast answer. Is there a script to bump minor versions, or is it a manual process so far?
daxpedda commentedon Jul 21, 2023
AFAIK a manual process. It should be straightforward with a couple of search-and-replace.
Vec
s of exported enums #3624gabrielDevlog commentedon Oct 7, 2023
Hi,
A release would be great. Is there any ETA for this ?
Thanks
daxpedda commentedon Oct 7, 2023
There is none AFAIK.
You can get the process started by replicating #3475.
gabrielDevlog commentedon Oct 7, 2023
Ok i'll try. Should i follow this process ? https://rustwasm.github.io/docs/wasm-bindgen/contributing/publishing.html
daxpedda commentedon Oct 7, 2023
If you just scroll up and look at the earlier discussion you will find all your answers.
I've done it manually so far because I didn't know about this tool, feel free to try it though.
ranile commentedon Oct 9, 2023
@daxpedda do you have permissions to make a release? I was thinking of setting up a GitHub actions workflow for it, but I don't have the permissions on crates.io and a secret needs be added before publishing can be done
daxpedda commentedon Oct 9, 2023
I do not, but the way it worked until now is to set everything up and ping Alex Crichton.
Making an action for it would be ideal though!
gabrielDevlog commentedon Oct 10, 2023
Well I'm trying manually but its not as easy as it seems. How do you get this value "APPROVED_SCHEMA_FILE_HASH" ?
https://github.com/rustwasm/wasm-bindgen/pull/3475/files#diff-515c29e8b5cfb75260c999069bc92df2bf301e4bbeddafd858b269cfac79d9f4R11
daxpedda commentedon Oct 11, 2023
You can run this test to see what the value is supposed to be:
https://github.com/rustwasm/wasm-bindgen/blob/bfe644fe13ee84b190345c53d419a0919a4a946f/crates/shared/src/schema_hash_approval.rs#L13-L16
daxpedda commentedon Oct 13, 2023
In the meantime, the schema was already bumped in #3651.
gabrielDevlog commentedon Oct 13, 2023
Just to let you know, I haven't had the time to take care of it yet, and I probably won't next week either.