Make Request and RequestBuilder implement IntoFuture#500
Closed
ultrabear wants to merge 1 commit intoranile:masterfrom
Closed
Make Request and RequestBuilder implement IntoFuture#500ultrabear wants to merge 1 commit intoranile:masterfrom
ultrabear wants to merge 1 commit intoranile:masterfrom
Conversation
Author
|
Some CI tests are failing because they try to grab |
Author
|
I do not know why the gloo-worker CI tests failed based on my PR, changes were only made in gloo-net and there does not appear to be a dependency chain where gloo-worker imports gloo-net |
Author
|
Closing as library appears unmaintained |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds IntoFuture implementations (and Future implementing types
RequestFutureandRequestBuilderFuture) forRequestandRequestBuilderThis makes it possible to have smoother usage of the API, with patterns like
Request::get("/foo").awaitnow being possible (previouslyRequest::get("/foo").send().await.This is my first time handwriting
Future's, so they are simple enum based state machines and or just wrap inner futures, I see no reasons they would be noticeably less performant than the previous implementation however.I realize as I write that it may have been a better idea to make RequestFuture and RequestBuilderFuture public in an unreachable module (not reference-able by userspace or documented publicly), if that change is wanted or to simply make them doc(hidden), or to just leave it be and give them a sentence of docs explaining what they are, I'm willing to do any of the three in a followup commit within this PR