Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain_mut is deprecated #1929

Open
paolobarbolini opened this issue Mar 31, 2024 · 3 comments
Open

retain_mut is deprecated #1929

paolobarbolini opened this issue Mar 31, 2024 · 3 comments

Comments

@paolobarbolini
Copy link
Contributor

paolobarbolini commented Mar 31, 2024

As described in the README, retain_mut has been deprecated with the release of Rust 1.61, which stabilized Vec::retain_mut and VecDeque::retain_mut.

I see this crate still makes peaks of 30k downloads a day, with Rust 1.61 having been released almost 2 years ago. Should an advisory be made for it?

@paolobarbolini
Copy link
Contributor Author

Cc @upsuper

@8573
Copy link
Contributor

8573 commented Apr 3, 2024

The crate's README says:

This crate has been deprecated. Rust 1.61 stabilized retain_mut for Vec and VecDeque, so you can use them directly. This crate is no longer maintained.

I don't think RustSec usually carries mere deprecation warnings, but the last sentence is more relevant.

@upsuper
Copy link

upsuper commented Apr 3, 2024

While I'm not sure how useful such an advisory would be, I'm not against issuing one. It is indeed unmaintained, but on the other hand, it is also very unlikely keeping the current implementation would have any security implication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants