Conversation
Member
|
Sorry, had failed to watch this repo before -- have done so now. |
djc
reviewed
Dec 5, 2025
| } | ||
|
|
||
| // and size (impossible if hash is correct, but should make us distrust the data) | ||
| if p.attachment.size != bytes.len() { |
Member
There was a problem hiding this comment.
If this is impossible, why are we doing it? What do you mean by "should make us distrust the data"? If we want to do both, should we check size first?
Member
Author
There was a problem hiding this comment.
This is just maintaining healthy distrust of the upstream data, rather than doing garbage-in/garbage-out.
ctz
force-pushed
the
jbp-mirror
branch
2 times, most recently
from
93c8414 to
c64a93c
Compare
This fetches filters from Mozilla's preferences backend, and then packages them into a simplified format (directory of files, plus a JSON manifest).
djc
approved these changes
Dec 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.