lib: use ext helper in more places, test custom exts. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was no test coverage for custom extensions in certificates or CSRs. This commit adds a simple example of encoding a custom extension, and then demonstrating that it can be parsed with `x509-parser`, both in a serialized certificate and in a CSR. There's no support in webpki, openssl-rs or botan-rs for handling custom extensions so no test coverage for those libraries is possible at this time.
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 70.28% 71.90% +1.62%
==========================================
Files 7 7
Lines 1898 1876 -22
==========================================
+ Hits 1334 1349 +15
+ Misses 564 527 -37
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Previously when writing CSR DER from `CertificateParams` that specified custom extensions, but did not specify any SANs, the serialization code would skip over writing the PKCS9 extension request attribute. This commit updates the serialization logic to ensure the attribute is written when either SANs are provided, or custom extensions are present. Prior to this update, the modified `test_x509_custom_ext` test fails, reproducing the problem reported in the issue tracker: ``` 'test_x509_custom_ext::custom_ext' panicked at 'missing requested extensions' ``` With the update, it passes again.
est31
approved these changes
Sep 10, 2023
10 tasks
djc
approved these changes
Sep 11, 2023
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates a couple places that were writing x509 extensions by hand to use the existing
write_x509_extensionhelper instead.Since custom extensions are a bit trickier a unit test for custom extensions in CSRs and certificates is added before refactoring the existing code to use the helper. This helps ensure the change is a no-op from the perspective of users.
With the updated test, it was possible to demonstrate a bug similar to #122. The CSR serialization logic requiring SANs to be present in order to emit the custom extensions into the CSR PKCS9 extension request attribute. This branch fixes the issue.