Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting up rcgen's lib.rs into smaller modules #139

Closed
7 of 8 tasks
est31 opened this issue Aug 23, 2023 · 3 comments
Closed
7 of 8 tasks

Splitting up rcgen's lib.rs into smaller modules #139

est31 opened this issue Aug 23, 2023 · 3 comments
Labels
next-major-release breaking changes put off until next major release

Comments

@est31
Copy link
Member

est31 commented Aug 23, 2023

Suggested by @cpu in #137.

I don't think we should overdo this, but there is certainly potential to split off modularized components from the main lib.rs file:

  • Split off oid module: fbd48cc
  • Split off csr module: e137bef
  • Split off key_pair module: 59253f5
  • Split off sign_algo module: 8b95395
  • Split off error module: e39892c
  • Split off crl module: c0344db
  • Replace OID_FOO with oid::FOO
  • (for the next breaking release, so probably after the next minor one) redesign the public API to be a little bit more modularized: move csr and crl stuff into own modules in the public API, maybe also the algos?
@cpu
Copy link
Member

cpu commented Apr 2, 2024

It feels like we're in pretty good shape here. I checked off the OID task, it was accomplished in f2789b3

Are there any other tasks folks had in mind for the last bullet or should we consider this done?

@cpu cpu added the next-major-release breaking changes put off until next major release label Apr 2, 2024
@djc
Copy link
Member

djc commented Apr 2, 2024

I think we're in a good place on this!

@est31
Copy link
Member Author

est31 commented Apr 3, 2024

I think we can close this as done. For the last bullet point, if it makes sense we can track it separately.

@est31 est31 closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major-release breaking changes put off until next major release
Projects
None yet
Development

No branches or pull requests

3 participants